Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Problem
Badge colors, including hover states, are currently composed using varying opacity, such as
bg-amber-100 dark:bg-amber-300/6 [button]:hover:bg-amber-200/70 dark:[button]:hover:bg-amber-200/9This creates the desired variation when the badges are on a plain background, such as the white background of light mode or the dark grey background in dark mode.
There are a couple of problems with this approach, though:
What this PR Does
I also added some extra tests for
cp/playgroundwhile I was here.Before
After
How to Reproduce
cp/playgroundand check out #f9c5d171a246a7c49602b465e5fc8f88d926117e (before), where I've added a playground demo, then check out the latest commit on this branch.